Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exporter queries, prometheus config file and dashboards for container deployments #188

Merged
merged 9 commits into from
Aug 7, 2020

Conversation

pmereddy1
Copy link
Contributor

@pmereddy1 pmereddy1 commented Aug 5, 2020

Description

  1. exporter queries to get CPU/Mem/Network/Disk metrics using pgnodemx extension
  2. Prometheus config file for containers
  3. pod_details & others Grafana dashboards

NOTE:

  1. Alertmanager configuration removed from the Prometheus config file
  2. These dashboards are imported using Grafana API directly during testing. Some tweaks may be required to import them using Grafana GUI or directly from a dashboard directory.

Fixes (issue) #

Depends on (issue) #

Type of change

Please check all options that are relevant

  • Bug fix (change which fixes an issue)
  • Feature (change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update only

How Has This Been Tested?

Tested Configuration:

  • CentOS, Specify version(s):
  • PostgreQL, Specify version(s):
  • docs tested with hugo <0.60
  • kubernetes 1.16

Tested with playbook(s):

Checklist:

  • I have made corresponding changes to:
    • the documentation
    • the release notes
    • the upgrade doc

@pmereddy1 pmereddy1 changed the title exporter queries, prometheus config file and dashboards exporter queries, prometheus config file and dashboards for container deployments Aug 5, 2020
Copy link
Collaborator

@keithf4 keithf4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing of note that Pramodh mentioned to me is that he had to manually modify these dashboards so that they could be imported via the Grafana API. We've had huge issues trying to make dashboards consistently compatible with the API import before and Grafana itself does not provide a means to export dashboards that are compatible with their import API. As of version 5.x of Grafana, we've been using automated provisioning and that is the method suggested from Grafana themselves for automated deployment.

If we can make sure that the method that these dashboards are installed in the containers uses the provisioning system, that will go a long way to ensuring the dashboards can be installed in a consistent manner for the foreseeable future.

@pmereddy1 For now, can you just upload the versions of the dashboard that are straight exports so we can try and see if we can get the provisioning system working with however this is going to be packaged? Please keep your modified ones around in case they are needed, tho.

hunleyd
hunleyd previously approved these changes Aug 6, 2020
hunleyd
hunleyd previously approved these changes Aug 6, 2020
exporter/postgres/queries_containers.yml Outdated Show resolved Hide resolved
@sharmay sharmay added this to the 4.4 milestone Aug 7, 2020
@sharmay sharmay added the FEATURE New feature or request label Aug 7, 2020
@sharmay sharmay merged commit 9e6741d into CrunchyData:development Aug 7, 2020
sharmay added a commit that referenced this pull request Aug 7, 2020
… deployments (#188) (#190)

* exporter queries, prometheus config file and dashboards

* same dashboards. But exported from Grafana GUI

* fix file permissions

* add links and fix units on network panel

* rename the 4 golden signals dashboard and add disk info to the saturation panel

* change metric names from ccp_container to ccp_nodemx, update dashboards with new names, remove invalid panel links

* rename queries_containers.yml to queries_nodemx.yml

* fix the description of process count metric

* exported dashboards to use externally

Co-authored-by: Pramodh Mereddy <[email protected]>
sharmay added a commit that referenced this pull request Aug 13, 2020
* exporter queries, prometheus config file and dashboards for container deployments (#188)

* exporter queries, prometheus config file and dashboards

* same dashboards. But exported from Grafana GUI

* fix file permissions

* add links and fix units on network panel

* rename the 4 golden signals dashboard and add disk info to the saturation panel

* change metric names from ccp_container to ccp_nodemx, update dashboards with new names, remove invalid panel links

* rename queries_containers.yml to queries_nodemx.yml

* fix the description of process count metric

* exported dashboards to use externally

* Container related updates to Prometheus Configs (#191)

* Update Prometheus Job Name and Source Label

The 'Crunchy Collect' container has been moved
from the Crunchy Containers project to the Postgres
Operator project and renamed to 'Crunchy Postgres
Exporter'.

This updates the Prometheus config file for container
deployments to match the new container name.

* Update queries_nodemx.yml File Comment

Updates the comment beginning and ending
comments from referring to 'pod_metrics.yml'
to the current name, 'queries_nodemx.yml'.

Co-authored-by: Pramodh Mereddy <[email protected]>
Co-authored-by: tjmoore4 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FEATURE New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants